Support for custom method qualifiers #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this and #12! I'll make time to get them merged this week. |
shanecav84
requested changes
Aug 10, 2023
| def ordered?(left_method, right_method) | ||
| comparison = COMPARISONS[cop_config['EnforcedStyle']] | ||
| raise Error, ERR_INVALID_COMPARISON if comparison.nil? | ||
|
|
||
| comparison.call(left_method, right_method) | ||
| end | ||
|
|
||
| def relevant_node?(node) | ||
| (node.defs_type? || node.def_type?) && !ignored_method?(node.method_name) |
There was a problem hiding this comment.
Did you mean to use the extracted .method_name to get the node's method name here and on line 153?
There was a problem hiding this comment.
Not really necessary, since it first check that the node is either def or defs, and the method_name handles send nodes, in order to get the defined method name, and not the name of the macro (e.g. get foo and not memoize in case of memoize def foo.
Though since it will return the same (node.method_name) for a node that is not of a send type, I can call it. I'd rather keep it as is, as method_name is defined on the class level
|
This has been released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10